[
https://issues.apache.org/jira/browse/FLINK-18164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147332#comment-17147332
]
Benchao Li edited comment on FLINK-18164 at 6/28/20, 12:57 PM:
---------------------------------------------------------------
[~Leonard Xu] Sorry to bother you about the issue status.
I closed this issue with a 'invalid' resolution before. I thought that
currently Flink's implementation is correct and no need to improve it.
Do you think that we need to borrow the configs from Calcite and improve
current `EQUALS` and `NOT_EQUALS` code generation logic?
Or we should describe current implementation design in the issue description?
was (Author: libenchao):
[~Leonard Xu] Sorry to bother you about the issue status.
I closed this issue with a 'invalid' resolution before. I thought that
currently Flink's implementation is correct and no need to improve it.
Do you think that we need to borrow the configs from Calcite and improve
current `EQUALS` and `NOT_EQUALS` code generation logic?
> null <> 'str' should be true
> ----------------------------
>
> Key: FLINK-18164
> URL: https://issues.apache.org/jira/browse/FLINK-18164
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
> Reporter: Benchao Li
> Priority: Major
>
> Currently, if we compare null with other literals, the result will always be
> false.
> It's because the code gen always gives a default value (false) for the
> result. And I think it's a bug if `null <> 'str'` is false.
> It's reported from user-zh:
> http://apache-flink.147419.n8.nabble.com/flink-sql-null-false-td3640.html
> CC [~jark] [~ykt836]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
