wuchong commented on a change in pull request #12806:
URL: https://github.com/apache/flink/pull/12806#discussion_r449405365
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -421,9 +421,9 @@ private static void validateColumnsAndWatermarkSpecs(
LogicalType watermarkOutputType =
watermark.getWatermarkExprOutputType().getLogicalType();
if (watermarkOutputType.getTypeRoot() !=
TIMESTAMP_WITHOUT_TIME_ZONE) {
throw new ValidationException(String.format(
- "Watermark strategy '%s' must be of
type TIMESTAMP but is of type '%s'.",
Review comment:
I added a test for empty char. The exception message will be `Watermark
strategy '''' must be`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]