[
https://issues.apache.org/jira/browse/FLINK-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nix updated FLINK-18504:
------------------------------
Description:
CsvTableSource has a three constructors and a public inner builder class.
There's a slight mismatch between the constructors and the builders, namely:
* The builder allows emptyColumnAsNull, but the constructors do not.
* There's one constructor that allows selectedFields, but the builder does not.
It feels a bit incongruous. Moreover, there's no way to use both these
features.
It might be good to align constructors and builder.
was:
CsvTableSource has a three constructors and a public inner builder class.
There's a slight mismatch between the constructors and the builders, namely:
* The builder allows emptyColumnAsNull, but the constructors do not.
* There's one constructor that allows selectedFields, but the builder does not.
It feels a bit incongruous. Moreover, there's no way to use both these
features.
It might be good to align constructor and builders.
> Mismatch between CsvTableSource constructor and builder params
> --------------------------------------------------------------
>
> Key: FLINK-18504
> URL: https://issues.apache.org/jira/browse/FLINK-18504
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
> Affects Versions: 1.8.1, 1.8.2, 1.8.3, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0,
> 1.10.1
> Reporter: Chris Nix
> Priority: Minor
>
> CsvTableSource has a three constructors and a public inner builder class.
> There's a slight mismatch between the constructors and the builders, namely:
> * The builder allows emptyColumnAsNull, but the constructors do not.
> * There's one constructor that allows selectedFields, but the builder does
> not.
> It feels a bit incongruous. Moreover, there's no way to use both these
> features.
> It might be good to align constructors and builder.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
