[ https://issues.apache.org/jira/browse/FLINK-18504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152359#comment-17152359 ]
Chris Nix edited comment on FLINK-18504 at 7/6/20, 10:44 PM: ------------------------------------------------------------- I'm happy to implement this one. For note, I started on this path with a change to the python constructor at [https://github.com/apache/flink/pull/12824|https://github.com/apache/flink/pull/12824,] for https://issues.apache.org/jira/browse/FLINK-18488 . I can include any relevant changes there too. was (Author: chrisnix): I'm happy to implement this one. For note, I started on this path with a change to the python constructor at [https://github.com/apache/flink/pull/12824|https://github.com/apache/flink/pull/12824,]. I can include any relevant changes there too. > Mismatch between CsvTableSource constructor and builder params > -------------------------------------------------------------- > > Key: FLINK-18504 > URL: https://issues.apache.org/jira/browse/FLINK-18504 > Project: Flink > Issue Type: Improvement > Components: API / Core > Affects Versions: 1.8.1, 1.8.2, 1.8.3, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0, > 1.10.1 > Reporter: Chris Nix > Priority: Minor > > CsvTableSource has a three constructors and a public inner builder class. > There's a slight mismatch between the constructors and the builders, namely: > * The builder allows emptyColumnAsNull, but the constructors do not. > * There's one constructor that allows selectedFields, but the builder does > not. > It feels a bit incongruous. Moreover, there's no way to use both these > features. > It might be good to align constructors and builder. -- This message was sent by Atlassian Jira (v8.3.4#803005)