aljoscha opened a new pull request #12859:
URL: https://github.com/apache/flink/pull/12859
## What is the purpose of the change
This makes `AvroFactory` and the used method public where they were package
private before.
This fixes the problem that `AvroDeserializationSchema` was not working with
types generated from avrohugger. It could also just be seen as refactoring/code
cleanup.
I don't like making the `AvroFactory` public, ideally all the code would be
in one package and we could keep things package private. Any thoughts on this?
## Brief change log
- make `AvroFactory` `public`, it was package private before
- use `AvroFactory.extractAvroSpecificSchema` in `AvroDeserializationSchema`
## Verifying this change
This is covered by existing tests. I'm not adding an actual Scala test with
avrohugger. The fact that it now works with avrohugger is more a side effect of
the fact that we now use the correct way to get a schema.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: yes
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
Only internal changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
