wuchong commented on a change in pull request #12715:
URL: https://github.com/apache/flink/pull/12715#discussion_r452107948
##########
File path: docs/dev/table/connectors/elasticsearch.md
##########
@@ -126,6 +126,20 @@ Connector Options
<td>String</td>
<td>Delimiter for composite keys ("_" by default), e.g., "$" would
result in IDs "KEY1$KEY2$KEY3"."</td>
</tr>
+ <tr>
+ <td><h5>username</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Username used to connect to Elasticsearch instance.</td>
Review comment:
What do you think about adding more explanation about ES authentication
here? I guess not all the users know the auth feature of Elasticsearch. For
example:
```
Elasticsearch doesn't pre-bundled security feature, but you can enable it by
following the
[guideline](https://www.elastic.co/guide/en/elasticsearch/reference/7.x/configuring-security.html)
to secure an Elasticsearch cluster.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
