JingsongLi opened a new pull request #12864:
URL: https://github.com/apache/flink/pull/12864
## What is the purpose of the change
For the following DDL, we just omits the unrecognized property
'records-per-second'.
```
CREATE TABLE MyDataGen (
int_field int,
double_field double,
string_field varchar
) WITH (
'connector' = 'datagen',
'records-per-second' = '1' -- should be rows-per-second
)
``
We should throw Exceptions to tell users that they used a wrong property.
## Brief change log
- `DataGenTableSourceFactory`: Dynamic generation config options, validate
them, and check unconsumed keys.
- `BlackHoleTableSinkFactory`: Using helper.validate.
## Verifying this change
- `DataGeneratorSourceTest`
- `BlackHoleSinkFactoryTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: (no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no
- The S3 file system connector: (no
## Documentation
- Does this pull request introduce a new feature? (no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
