Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-181040537
I don't see much of a difference here.
(1) Of course, we can have a stoppable flag instead of the `JobType`; but I
don't see any advantage. Why should it be bad to add a job type -- it is
basically meta information in both cases anyway? And for batch jobs, being
stoppable does not make much sense anyway.
(2) From my point of view, all `StreamSource`s should be stoppable. I
cannot think of a source, that is not stoppable -- I am also wondering why
Kafka sources should not be stoppable properly (on stop, they just do not
consume any more data from Kafka).
(3) If we keep it as is, there is not reason to infer this. If we apply
your changes, I agree that it would make sense to detect and set the stoppable
flag automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
