[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136295#comment-15136295
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-181040537
I don't see much of a difference here.
(1) Of course, we can have a stoppable flag instead of the `JobType`; but I
don't see any advantage. Why should it be bad to add a job type -- it is
basically meta information in both cases anyway? And for batch jobs, being
stoppable does not make much sense anyway.
(2) From my point of view, all `StreamSource`s should be stoppable. I
cannot think of a source, that is not stoppable -- I am also wondering why
Kafka sources should not be stoppable properly (on stop, they just do not
consume any more data from Kafka).
(3) If we keep it as is, there is not reason to infer this. If we apply
your changes, I agree that it would make sense to detect and set the stoppable
flag automatically.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
