[ 
https://issues.apache.org/jira/browse/FLINK-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136784#comment-15136784
 ] 

ASF GitHub Bot commented on FLINK-3353:
---------------------------------------

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1598#issuecomment-181295170
  
    Thanks for the pull request. Your changes look sensible. Going to merge 
this later on.


> CSV-related tests may fail depending on locale
> ----------------------------------------------
>
>                 Key: FLINK-3353
>                 URL: https://issues.apache.org/jira/browse/FLINK-3353
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.0.0
>            Reporter: Stefano Baghino
>            Assignee: Stefano Baghino
>            Priority: Trivial
>             Fix For: 1.0.0
>
>
> As I've been running some tests, three suites 
> ({{KMeansWithBroadcastSetITCase.java}}, 
> {{ScalaCsvReaderWithPOJOITCase.scala}} and {{CsvReaderITCase.java}}) kept 
> failing locally because the expected results (string literals) were matched 
> against an object rendered as a string using the {{String.format}} method, a 
> method whose result depends on the default Locale; as my Locale (Italian) 
> renders doubles with a comma instead of a dot as the decimal separator, the 
> representation of doubles diverged from the expected one, thus making my 
> tests fail, despite the results actually being correct.
> As the result is hard-coded, it makes sense to explicitly use the US locale 
> to represent those object. I'll open a PR with my solution ASAP.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to