zentol commented on a change in pull request #12883: URL: https://github.com/apache/flink/pull/12883#discussion_r454219156
########## File path: flink-metrics/flink-metrics-slf4j/src/test/java/org/apache/flink/metrics/slf4j/Slf4jReporterFactoryTest.java ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.metrics.slf4j; + +import org.apache.flink.metrics.reporter.MetricReporterFactory; +import org.apache.flink.runtime.metrics.MetricReporterSetupTestBase; + +import java.util.Collections; +import java.util.List; + +/** + * Tests for loading the {@link Slf4jReporterFactory}. + */ +public class Slf4jReporterFactoryTest extends MetricReporterSetupTestBase { + + @Override + protected List<Class<? extends MetricReporterFactory>> getMetricReporterFactoryClass() { Review comment: The Prometheus e2e test very much focuses on this, and tests all configurations one can think of (jar in plugins/lib, loaded via reflection/factory). The reason it is necessary to test as an e2e test is that this feature working in production is reliant on the packaging; if the services stuff isn't included in the jar then it just won't work, and the unit test cannot catch that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
