dannycranmer commented on a change in pull request #12881:
URL: https://github.com/apache/flink/pull/12881#discussion_r454860445
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/StartingPosition.java
##########
@@ -0,0 +1,106 @@
+/*
Review comment:
We cannot use `SentinelSequenceNumber` to achieve what this class does,
as `SentinelSequenceNumber` is an enum. We could get rid of
`SentinelSequenceNumber` in favour of this, however that class has a lot of
references and would be a big refactor. Also I think semantically they differ.
Also looking at the code, `SentinelSequenceNumber` is potentially serialised
and therefore we would need to migrate snapshots or handle deserialisation
mappings which is risky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
