aljoscha commented on a change in pull request #12904:
URL: https://github.com/apache/flink/pull/12904#discussion_r454923840
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/OperationTreeBuilder.java
##########
@@ -402,19 +402,20 @@ private ResolvedExpression
resolveSingleExpression(Expression expression, Expres
}
public QueryOperation sort(List<Expression> fields, QueryOperation
child) {
-
ExpressionResolver resolver = getResolver(child);
List<ResolvedExpression> resolvedFields =
resolver.resolve(fields);
return sortOperationFactory.createSort(resolvedFields, child,
resolver.postResolverFactory());
}
public QueryOperation limitWithOffset(int offset, QueryOperation child)
{
- return sortOperationFactory.createLimitWithOffset(offset,
child);
+ ExpressionResolver resolver = getResolver(child);
Review comment:
You would have to explain to me why this is necessary. 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
