wuchong commented on a change in pull request #12900:
URL: https://github.com/apache/flink/pull/12900#discussion_r455525030
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala
##########
@@ -18,23 +18,23 @@
package org.apache.flink.table.planner.codegen
+import java.util.TimeZone
+
+import org.apache.calcite.avatica.util.DateTimeUtils
Review comment:
What's the preferred import order? AFAIK, the code style suggests to put
flink imports first:
https://flink.apache.org/contributing/code-style-and-quality-formatting.html#imports
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java
##########
@@ -249,7 +251,15 @@ public static DataFormatConverter
getConverterForDataType(DataType originDataTyp
DataTypes.INT().bridgedTo(Integer.class));
case ROW:
case STRUCTURED_TYPE:
- CompositeType compositeType = (CompositeType)
fromDataTypeToTypeInfo(dataType);
+ TypeInformation<?> asTypeInfo =
fromDataTypeToTypeInfo(dataType);
+ if (asTypeInfo instanceof WrapperTypeInfo &&
clazz == RowData.class) {
+ LogicalType realLogicalType =
((WrapperTypeInfo<?>) asTypeInfo).toLogicalType();
+ return new
RowDataConverter(getFieldCount(realLogicalType));
Review comment:
In which case will we reach here?
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/AsyncLookupJoinHarnessTest.java
##########
@@ -75,18 +74,19 @@
private static final int ASYNC_TIMEOUT_MS = 3000;
private final TypeSerializer<RowData> inSerializer = new
RowDataSerializer(
- new ExecutionConfig(),
new IntType(),
new VarCharType(VarCharType.MAX_LENGTH));
- private final RowDataHarnessAssertor assertor = new
RowDataHarnessAssertor(new TypeInformation[]{
- Types.INT,
- Types.STRING,
- Types.INT,
- Types.STRING
+ private final RowDataHarnessAssertor assertor = new
RowDataHarnessAssertor(new LogicalType[]{
+ new IntType(),
+ new VarCharType(VarCharType.MAX_LENGTH),
+ new IntType(),
+ new VarCharType(VarCharType.MAX_LENGTH)
Review comment:
Keep to use DataType here?
```java
DataTypes.INT().getLogicalType(),
DataTypes.STRING().getLogicalType(),
DataTypes.INT().getLogicalType(),
DataTypes.STRING().getLogicalType()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
