[ 
https://issues.apache.org/jira/browse/FLINK-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137042#comment-15137042
 ] 

ASF GitHub Bot commented on FLINK-3367:
---------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1601

    [FLINK-3367] [core] Drop AbstractID#toShortString()

    Drops the `toShortString` method in `AbstractID`.
    
    @aljoscha Is that OK in the RocksDB state backend?
    
    @gyfora As discussed offline, I've still shortened the ID in the DB state 
backend, because this a requirement from certain DBs for table names.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 3357-drop_short

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1601
    
----
commit 0fd11a9ce65755dee2be3d42ae8dff9dcca28787
Author: Ufuk Celebi <[email protected]>
Date:   2016-02-08T15:05:27Z

    [FLINK-3367] [core] Drop AbstractID#toShortString()

----


> Annotate all user-facing API classes with @Public or @PublicEvolving
> --------------------------------------------------------------------
>
>                 Key: FLINK-3367
>                 URL: https://issues.apache.org/jira/browse/FLINK-3367
>             Project: Flink
>          Issue Type: Task
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>             Fix For: 1.0.0
>
>
> At the moment, only stable public classes are annotated with @Public. It is 
> not possible to identify whether a non-annotated class is supposed to be 
> API-facing or not.
> This issue proposes to annotate all API classes either with @Public or 
> @PublicEvolving. Classes which are not annotated belong to Flink's internals.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to