TsReaper opened a new pull request #12924:
URL: https://github.com/apache/flink/pull/12924
## What is the purpose of the change
In `BinaryWriter`, we have special logic when dealing null values of
`DecimalType` and `TimestampType`. However, the currently deprecated (but still
largely in use) `setNullAt` method cannot determine the type of the specified
field so this method cannot handle `DecimalType` and `TimestampType` correctly,
thus causing the bug in FLINK-14848.
This PR remove deprecated `setNullAt` and `write` methods in `BinaryWriter`
and use `NullSetter`/`ValueSetter` to replace them.
## Brief change log
- Remove deprecated setNullAt/write in BinaryWriter and use
NullSetter/ValueSetter instead.
## Verifying this change
This change is already covered by existing tests (including binary writer
tests, serializer tests, IT cases involving code generation, etc.). This PR
also adds some test cases for verifying.
Note that this PR removes two test cases in which Kryo serializers are
specified in the `ExecutionConfig`. This feature is not supported in table API.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: yes, but they're still compatible
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
