yangyichao-mango commented on a change in pull request #12665:
URL: https://github.com/apache/flink/pull/12665#discussion_r456856357
##########
File path: docs/dev/event_time.zh.md
##########
@@ -67,21 +67,18 @@ stream
{% highlight python %}
env = StreamExecutionEnvironment.get_execution_environment()
-env.set_stream_time_characteristic(TimeCharacteristic.EventTime)
+env.set_stream_time_characteristic(TimeCharacteristic.ProcessingTime)
-# alternatively:
-# env.set_stream_time_characteristic(TimeCharacteristic.IngestionTime)
-# env.set_stream_time_characteristic(TimeCharacteristic.ProcessingTime)
{% endhighlight %}
Review comment:
Hi,
这部分在rebase的时候不小心改错了。已经修复。
##########
File path: docs/dev/event_time.zh.md
##########
@@ -24,13 +24,13 @@ specific language governing permissions and limitations
under the License.
-->
-本节你将学到如何写可感知时间变化的 Flink 程序，可以先看看[实时流处理]({% link
concepts/timely-stream-processing.zh.md %})了解相关概念。
+在本节中，你将学习编写可对时间进行感知（time-aware）的 Flink 程序。可以参阅[实时流处理]({% link
concepts/timely-stream-processing.zh.md %})小节以了解实时流处理的概念。
Review comment:
> `可对时间进行感知` 这里使用原来的 `可感知时间变化` 的会更好吗？现在的意思也说的通，读起来有点拗口
done.
##########
File path: docs/dev/event_timestamp_extractors.zh.md
##########
@@ -25,83 +25,50 @@ under the License.
* toc
{:toc}
-As described in [timestamps and watermark handling]({{ site.baseurl
}}/dev/event_timestamps_watermarks.html),
-Flink provides abstractions that allow the programmer to assign their own
timestamps and emit their own watermarks. More specifically,
-one can do so by implementing one of the `AssignerWithPeriodicWatermarks` and
`AssignerWithPunctuatedWatermarks` interfaces, depending
-on the use case. In a nutshell, the first will emit watermarks periodically,
while the second does so based on some property of
-the incoming records, e.g. whenever a special element is encountered in the
stream.
+如[生成 Watermark]({{ site.baseurl }}/zh/dev/event_timestamps_watermarks.html)
小节中所述，Flink 提供的抽象方法可以允许用户自己去定义时间戳分配方式和 watermark 发出的方式。具体就是你可以通过实现
`WatermarkGenerator` 接口来实现上述功能。
Review comment:
> 这里建议使用 `{%link dev/event_timestamps_watermarks.zh.md %}` 的形式写链接，
> 具体可以参考
[邮件列表](http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Reminder-Prefer-link-tag-in-documentation-td42362.html)
>
> `watermark 发出` -> `watermark 生成` 是否更好一些，标题也是生成，这样可以全文进行统一
>
> `具体就是你可以通过实现` -> `你可以通过实现` 这样会好一些吗？
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
