godfreyhe commented on a change in pull request #12934:
URL: https://github.com/apache/flink/pull/12934#discussion_r457142140
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/Executor.java
##########
@@ -79,13 +79,23 @@
/**
* Lists all registered catalogs.
*/
- List<String> listCatalogs(String sessionid) throws
SqlExecutionException;
+ List<String> listCatalogs(String sessionId) throws
SqlExecutionException;
+
+ /**
+ * List current catalog.
+ */
+ String listCurrentCatalog(String sessionId) throws
SqlExecutionException;
/**
* Lists all databases in the current catalog.
*/
List<String> listDatabases(String sessionId) throws
SqlExecutionException;
+ /**
+ * List current database.
+ */
+ String listCurrentDatabase(String sessionId) throws
SqlExecutionException;
Review comment:
ditto
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/Executor.java
##########
@@ -79,13 +79,23 @@
/**
* Lists all registered catalogs.
*/
- List<String> listCatalogs(String sessionid) throws
SqlExecutionException;
+ List<String> listCatalogs(String sessionId) throws
SqlExecutionException;
+
+ /**
+ * List current catalog.
+ */
+ String listCurrentCatalog(String sessionId) throws
SqlExecutionException;
Review comment:
we should not introduce new methods, instead, we can call `executeSql`
directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
