kl0u commented on a change in pull request #12791:
URL: https://github.com/apache/flink/pull/12791#discussion_r457255482
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java
##########
@@ -313,26 +326,34 @@ public YarnLocalResourceDescriptor uploadFlinkDist(final
Path localJarPath) thro
* @return list of class paths with the file name
*/
List<String> registerProvidedLocalResources() {
+ return registerLocalResources(providedSharedLibs,
LocalResourceVisibility.PUBLIC, LocalResourceType.FILE);
Review comment:
Why is this new method needed?
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java
##########
@@ -313,26 +326,34 @@ public YarnLocalResourceDescriptor uploadFlinkDist(final
Path localJarPath) thro
* @return list of class paths with the file name
*/
List<String> registerProvidedLocalResources() {
+ return registerLocalResources(providedSharedLibs,
LocalResourceVisibility.PUBLIC, LocalResourceType.FILE);
Review comment:
Why is this new method needed? Can't we remove it and leave it as it was
before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
