rmetzger commented on pull request #12823: URL: https://github.com/apache/flink/pull/12823#issuecomment-661104442
That's it with my initial review so far. I haven't fully checked if there are more places to get rid of duplicate code by having some generic Hadoop Utilities, but if the intention of this change is to reduce the amount of duplicate or similar code, then my gut feeling is that we need to remove more than 50 lines of code (to justify adding a new module, and introducing potential dependency problems) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
