fsk119 commented on pull request #11896: URL: https://github.com/apache/flink/pull/11896#issuecomment-661856107
Hi, @hackergin. I think this pr is not finished. I list some problems here: 1. you don't add any docs about this format; 2. the tests are too weak to verify whether this format works fine. I think you still have to add test verify that you can get single value format by parsing option `'format'`. I think `JsonFormatFactoryTest` is a good example to follow up; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
