[
https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137495#comment-15137495
]
ASF GitHub Bot commented on FLINK-3355:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1608
[FLINK-3355] [rocksdb backend] Allow passing options to the RocksDB backend
This introduces an `OptionsFactory` to lazily create RocksDB Options and
uses those to initialize the
RocksDB instance.
Tests: The necessary flag `setCreateIfMissing(true)` is defined on the
options as part of the lazy creation of the RocksDB options. That way, it
doubles as a test that the options are actually passed to the
`AbstractRocksDBState`.
At the moment, this does not persist the options factory with the
checkpoint, but uses upon restore the same factory that is defined on the state
backend. We have to check if that may cause issues with safepoints.
Note: This also cleans up the generics in the RocksDB state classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink rocks_options
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1608
----
commit 5a7112978164fad896a6c48b2e0e6215172df963
Author: Stephan Ewen <[email protected]>
Date: 2016-02-08T18:55:29Z
[FLINK-3355] [rocksdb backend] Allow passing options to the RocksDB backend.
This also cleans up the generics in the RocksDB state classes.
----
> Allow passing RocksDB Option to RocksDBStateBackend
> ---------------------------------------------------
>
> Key: FLINK-3355
> URL: https://issues.apache.org/jira/browse/FLINK-3355
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Gyula Fora
> Assignee: Stephan Ewen
> Priority: Critical
>
> Currently the RocksDB state backend does not allow users to set the
> parameters of the created store which might lead to suboptimal performance on
> some workloads.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
