tillrohrmann commented on a change in pull request #12563:
URL: https://github.com/apache/flink/pull/12563#discussion_r458594116
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerSharedServices.java
##########
@@ -144,11 +146,13 @@ public static JobManagerSharedServices fromConfiguration(
final String[] alwaysParentFirstLoaderPatterns =
CoreOptions.getParentFirstLoaderPatterns(config);
+ final boolean failOnJvmMetaspaceOomError =
config.getBoolean(CoreOptions.FAIL_ON_USER_CLASS_LOADING_METASPACE_OOM);
final BlobLibraryCacheManager libraryCacheManager =
new BlobLibraryCacheManager(
blobServer,
FlinkUserCodeClassLoaders.ResolveOrder.fromString(classLoaderResolveOrder),
- alwaysParentFirstLoaderPatterns);
+ alwaysParentFirstLoaderPatterns,
+ fatalErrorHandler);
Review comment:
```suggestion
failOnJvmMetaspaceOomError ? fatalErrorHandler
: null);
```
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1326,7 +1326,8 @@ private JobManagerConnection associateWithJobManager(
final LibraryCacheManager libraryCacheManager = new
BlobLibraryCacheManager(
blobCacheService.getPermanentBlobService(),
taskManagerConfiguration.getClassLoaderResolveOrder(),
-
taskManagerConfiguration.getAlwaysParentFirstLoaderPatterns());
+
taskManagerConfiguration.getAlwaysParentFirstLoaderPatterns(),
+ fatalErrorHandler);
Review comment:
Here we are not respecting `FAIL_ON_USER_CLASS_LOADING_METASPACE_OOM`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
