aljoscha commented on a change in pull request #12959:
URL: https://github.com/apache/flink/pull/12959#discussion_r458748160
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunctionHelper.java
##########
@@ -215,6 +216,38 @@ public static void validateClass(Class<? extends
UserDefinedFunction> functionCl
validateClass(functionClass, true);
}
+ /**
+ * Validates a {@link UserDefinedFunction} class for usage in the
runtime.
+ *
+ * <p>Note: This is for the final validation when actual {@link
DataType}s for arguments and result
Review comment:
just a nitpick but you can write `{@link DataType DataTypes}`, then it
will link to `DataType` but the link will be called `DataTypes`.
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdHandlerTestBase.scala
##########
@@ -749,7 +749,7 @@ class FlinkRelMdHandlerTestBase {
false,
false,
false,
- Seq(Integer.valueOf(0)).toList,
+ Seq(Integer.valueOf(3)).toList,
Review comment:
What's going on here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
