dannycranmer commented on a change in pull request #12944:
URL: https://github.com/apache/flink/pull/12944#discussion_r459489336
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -204,6 +224,12 @@ under the License.
<include>com.amazonaws:*</include>
<include>com.google.protobuf:*</include>
<include>org.apache.httpcomponents:*</include>
+
<include>software.amazon.awssdk:*</include>
+
<include>software.amazon.eventstream:*</include>
+
<include>software.amazon.ion:*</include>
+
<include>org.reactivestreams:*</include>
+
<include>io.netty:*</include>
+
<include>com.typesafe.netty:*</include>
Review comment:
@rmetzger I have updated the NOTICE file as requested. All of the new
dependencies are Apache 2.0 except reactive streams is creative commons. Is
that ok to bundle? I could not shade that one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
