[
https://issues.apache.org/jira/browse/FLINK-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164260#comment-17164260
]
Jark Wu commented on FLINK-18640:
---------------------------------
Hi [~良], before opening pull request, we should reach a consensus on the
solution first.
Regarding to your fix in the PR, you are adding a {{schema}} name parameter to
each of the methods of {{JdbcDialect}}.
However, {{schema}} is a very specific concept in PG and {{JdbcDialect}} is a
general abstraction for all the databases.
Therefore, I suggest not adding {{schema}} to {{JdbcDialect}}.
After some thinking of the splitting by ".", I think it might be the best way
for now. As we are also using "schema.table_name" as table name in the PG
catalog.
Besides, I think it's very rare that the original table name contains "."
> Flink jdbc not support postgresql with schema
> ---------------------------------------------
>
> Key: FLINK-18640
> URL: https://issues.apache.org/jira/browse/FLINK-18640
> Project: Flink
> Issue Type: Bug
> Components: Connectors / JDBC
> Affects Versions: 1.9.1, 1.10.1
> Reporter: 毛宗良
> Priority: Major
> Labels: pull-request-available
>
> Flink jdbc throw exceptions when read a postgresql table with scheam, like
> "ods.t_test". BY debugging the source code, I found a bug about dealing the
> table name.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
