azagrebin commented on a change in pull request #12981:
URL: https://github.com/apache/flink/pull/12981#discussion_r460109160
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/UnsafeMemoryBudget.java
##########
@@ -122,15 +128,15 @@ void reserveMemory(long size) throws
MemoryReservationException {
if (availableOrReserved >= size) {
return;
}
- if (sleeps >= MAX_SLEEPS) {
+ if (sleeps >= maxSleeps) {
break;
}
- if (sleeps >= RETRIGGER_GC_AFTER_SLEEPS) {
- // trigger again VM's Reference
processing if we have to wait longer
- System.gc();
- }
try {
if
(!JavaGcCleanerWrapper.tryRunPendingCleaners()) {
+ if (sleeps >=
RETRIGGER_GC_AFTER_SLEEPS) {
Review comment:
no, it is even a fix, see #12980. the commit is from #12980
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
