Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181824403
Hi Timo, the PR looks really good :-)
I found the following issues / questions:
- Accessing of POJO fields might not work.
- Can you add method comments to the code generation methods in
`CodeGenerator` and `CodeGenUtils`?
- Would it make sense to separate the function and expression code gen,
i.e., split the `CodeGenerator` class?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
