twalthr commented on a change in pull request #12987:
URL: https://github.com/apache/flink/pull/12987#discussion_r460759368
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/SinkCodeGenerator.scala
##########
@@ -102,7 +102,8 @@ object SinkCodeGenerator {
}
val consumedDataType = sink.getConsumedDataType
- val outTerm = genToExternal(ctx, physicalOutputType, afterIndexModify)
+ // still uses the old conversion stack due to FLINK-18701
Review comment:
Yes, I think we should merge this even without first addressing
FLINK-18701. The issue seems tricky and has no assignee yet. But we should fix
FLINK-18701 for 1.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
