wuchong commented on a change in pull request #12882:
URL: https://github.com/apache/flink/pull/12882#discussion_r460779297
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java
##########
@@ -97,7 +99,7 @@ default String quoteIdentifier(String identifier) {
*/
default String getRowExistsStatement(String tableName, String[]
conditionFields) {
String fieldExpressions = Arrays.stream(conditionFields)
- .map(f -> quoteIdentifier(f) + "=?")
+ .map(f -> format("%s = :%s", quoteIdentifier(f), f))
Review comment:
Using `VALUES(id)` might be more efficient than set values `:id` in
statement. I would like to keep it. We can use the named variables in future
Oracle dialect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
