wangyang0918 commented on a change in pull request #12995:
URL: https://github.com/apache/flink/pull/12995#discussion_r461446683
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the
Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
Currently, we do not bundle `com.github.mifmif:generex:1.0.2` into the
flink-dist jar. Because we only have `<include>com.mifmif:*</include>` in
flink-kubernetes/pom.xml.
Maybe it is typo and should be `com.github.mifmif`. I will fix it.
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the
Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
Currently, we do not bundle `com.github.mifmif:generex:1.0.2` into the
flink-dist jar. Because we only have `<include>com.mifmif:*</include>` in
flink-kubernetes/pom.xml.
Maybe it is a typo and should be `com.github.mifmif`. I will fix it.
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the
Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
Because we do not go into the code path which are using
`com.mifmif.common.regex.Generex` in fabric8 kubernetes-client. So do you
suggest to completely remove the `com.github.mifmif` dependency?
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the
Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
I prefer bundling `com.github.mifmif` into the flink-dist jar. It is
very small and we may go into the code path in the future, especially when
introducing some flexible features(e.g. pod template).
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the
Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
Yeah, i will remove the dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
