rkhachatryan commented on a change in pull request #13022:
URL: https://github.com/apache/flink/pull/13022#discussion_r462408619
##########
File path: docs/monitoring/metrics.md
##########
@@ -1470,19 +1470,11 @@ Certain RocksDB native metrics are available but
disabled by default, you can fi
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="4"><strong>Operator</strong></th>
- <td>currentInput1Watermark</td>
+ <th rowspan="3"><strong>Operator</strong></th>
+ <td>currentInput<strong>N</strong>Watermark</td>
<td>
- The last watermark this operator has received in its first input (in
milliseconds).
- <p><strong>Note:</strong> Only for operators with 2 inputs.</p>
- </td>
- <td>Gauge</td>
- </tr>
- <tr>
- <td>currentInput2Watermark</td>
- <td>
- The last watermark this operator has received in its second input (in
milliseconds).
- <p><strong>Note:</strong> Only for operators with 2 inputs.</p>
+ The last watermark this operator has received in its
<strong>N'th</strong> input (in milliseconds). For example
currentInput<strong>1</strong>Watermark,
currentInput<strong>2</strong>Watermark, ...
Review comment:
nit: mention that N is 1-based
##########
File path: docs/monitoring/metrics.md
##########
@@ -1470,19 +1470,11 @@ Certain RocksDB native metrics are available but
disabled by default, you can fi
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="4"><strong>Operator</strong></th>
- <td>currentInput1Watermark</td>
Review comment:
I see this metric is still there. Shouldn't we mark it deprecated (in
docs) instead of removing, to avoid forcing users to update their monitoring
scripts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
