zentol commented on a change in pull request #13020:
URL: https://github.com/apache/flink/pull/13020#discussion_r463493044



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java
##########
@@ -114,6 +115,21 @@ protected void respondAsLeader(ChannelHandlerContext ctx, 
RoutedRequest routedRe
                        log.trace("Received request " + httpRequest.uri() + 
'.');
                }
 
+               synchronized (this) {
+                       if (terminationFuture != null) {
+                               String errorMsg = "The handler instance for " + 
untypedResponseMessageHeaders.getTargetRestEndpointURL()
+                                       + " had already been closed";
+                               log.warn(errorMsg);
+                               HandlerUtils.sendErrorResponse(

Review comment:
       they are still useful for preventing   something similar from happening 
again.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to