[
https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139942#comment-15139942
]
ASF GitHub Bot commented on FLINK-2523:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388350
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -141,9 +146,16 @@ public TaskDeploymentDescriptor(
List<BlobKey> requiredJarFiles, List<URL>
requiredClasspaths,
int targetSlotNumber) {
- this(appId, jobID, vertexID, executionId, taskName,
indexInSubtaskGroup, numberOfSubtasks, attemptNumber,
- jobConfiguration, taskConfiguration,
invokableClassName, producedPartitions,
- inputGates, requiredJarFiles,
requiredClasspaths, targetSlotNumber, null, -1);
+ this(appId, jobID, vertexID, executionId, new
ExecutionConfig(), taskName, indexInSubtaskGroup,
--- End diff --
This constructor only exists for tests. The executionConfig in the TDD is
the change of this pull request, so here the new ExecutionConfig is just to not
break the already existing tests that were testing other parts of the
functionality of the TDD. New tests are added to test the new functionality.
> Make task canceling interrupt interval configurable
> ---------------------------------------------------
>
> Key: FLINK-2523
> URL: https://issues.apache.org/jira/browse/FLINK-2523
> Project: Flink
> Issue Type: Improvement
> Components: TaskManager
> Affects Versions: 0.10.0
> Reporter: Stephan Ewen
> Assignee: Klou
> Fix For: 1.0.0
>
>
> When a task is canceled, the cancellation calls periodically "interrupt()" on
> the task thread, if the task thread does not cancel with a certain time.
> Currently, this value is hard coded to 10 seconds. We should make that time
> configurable.
> Until then, I would like to increase the value to 30 seconds, as many tasks
> (here I am observing it for Kafka consumers) can take longer then 10 seconds
> for proper cleanup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
