DG-Wangtao commented on a change in pull request #13045:
URL: https://github.com/apache/flink/pull/13045#discussion_r464478544



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointRequestDeciderTest.java
##########
@@ -119,13 +119,13 @@ public void testQueueSizeLimitPriority() {
        public void testSavepointTiming() {
                testTiming(regularSavepoint(), TriggerExpectation.IMMEDIATELY);
                testTiming(periodicSavepoint(), TriggerExpectation.IMMEDIATELY);
-               testTiming(nonForcedSavepoint(), 
TriggerExpectation.AFTER_PAUSE);
+               testTiming(nonForcedSavepoint(), 
TriggerExpectation.IMMEDIATELY);

Review comment:
       Hi, @klion26  @rkhachatryan , I add three test functions:
   * testNonForcedEnqueueOnTooManyPending: testing for nonforced savepoint on 
too many pending
   * testNonForcedUserSubmittedPrioritized: testing for order of nonforced 
savpoint and nonForcedPeriodicSavepoint
   * testNonForcedSavepointPrioritized: testing for order of nonForcedSavepoint 
and regularCheckpoint
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to