zhuzhurk commented on a change in pull request #12917:
URL: https://github.com/apache/flink/pull/12917#discussion_r465530665
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolInteractionsTest.java
##########
@@ -80,24 +65,12 @@
@Test
public void testSlotAllocationNoResourceManager() throws Exception {
- final JobID jid = new JobID();
-
- try (SlotPool pool = new SlotPoolImpl(
- jid,
- SystemClock.getInstance(),
- TestingUtils.infiniteTime(),
- TestingUtils.infiniteTime(),
- TestingUtils.infiniteTime()
- )) {
- pool.start(JobMasterId.generate(), "foobar",
testMainThreadExecutor.getMainThreadExecutor());
- Scheduler scheduler = new
SchedulerImpl(LocationPreferenceSlotSelectionStrategy.createDefault(), pool);
-
scheduler.start(testMainThreadExecutor.getMainThreadExecutor());
+ try (SlotPool pool = createAndSetUpSlotPool(false)) {
Review comment:
I'd prefer to have a `createAndSetUpSlotPoolWithoutResourceManager()` to
replace `createAndSetUpSlotPool(false)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
