zentol commented on a change in pull request #13042:
URL: https://github.com/apache/flink/pull/13042#discussion_r465931031
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
##########
@@ -78,4 +79,13 @@
.text("Enable the slot spread out allocation
strategy. This strategy tries to spread out " +
"the slots evenly across all available
%s.", code("TaskExecutors"))
.build());
+
+ @Documentation.Section(Documentation.Sections.EXPERT_CLUSTER)
+ public static final ConfigOption<Boolean> HALT_ON_FATAL_ERROR =
+ key("cluster.processes.halt-on-fatal-error")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether processes should halt on
fatal errors instead of performing a graceful shutdown. " +
+ "In some environments (e.g. Java 8 with the G1
garbage collector), a regular graceful shutdown can lead " +
+ "to a JVM deadlock. See:
https://issues.apache.org/jira/browse/FLINK-16510";);
Review comment:
```suggestion
.withDescription(Description.builder().text(
"Whether processes should halt on fatal errors
instead of performing a graceful shutdown. " +
"In some environments (e.g. Java 8 with
the G1 garbage collector), a regular graceful shutdown can lead " +
"to a JVM deadlock. See %s for
details.",
link("https://issues.apache.org/jira/browse/FLINK-16510";, "FLINK-16510")
.build());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
