KarmaGYZ commented on a change in pull request #13051:
URL: https://github.com/apache/flink/pull/13051#discussion_r466102349
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -1256,7 +1256,10 @@ void checkTaskManagerTimeoutsAndRedundancy() {
}
int slotsDiff = redundantTaskManagerNum *
numSlotsPerWorker - freeSlots.size();
- if (slotsDiff > 0) {
+ if (freeSlots.size() == slots.size()) {
Review comment:
If job's failover takes a long time, we could run into this scenario as
well. In that case, the redundant TM mechanism will not take effect as
expected. WDYT about this?
cc @tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
