zentol commented on a change in pull request #13031:
URL: https://github.com/apache/flink/pull/13031#discussion_r466998507
##########
File path:
flink-core/src/main/java/org/apache/flink/util/ChildFirstClassLoader.java
##########
@@ -73,9 +71,7 @@ public ChildFirstClassLoader(
// let URLClassLoader do it, which will
eventually call the parent
c =
super.loadClassWithoutExceptionHandling(name, resolve);
}
- }
-
- if (resolve) {
+ } else if (resolve) {
Review comment:
Ok that makes sense, let's move it into another commit and then we're
good to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
