klion26 commented on a change in pull request #13091:
URL: https://github.com/apache/flink/pull/13091#discussion_r467544272
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -318,6 +318,7 @@ public CheckpointCoordinator(
this.clock,
this.minPauseBetweenCheckpoints,
this.pendingCheckpoints::size,
+ () -> this.lastCheckpointCompletionRelativeTime,
Review comment:
@rkhachatryan thanks for the fix.
After this change, the behavior is equal to 1.10 and would respect the
min-pause setting now.
I'm wandering do we need to make the `lastCheckpointCompletionRelativeTime`
and `pendingCheckpoints.size` volatile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]