gyfora commented on pull request #13103:
URL: https://github.com/apache/flink/pull/13103#issuecomment-671313516


   > Thanks for creating this PR @gyfora. The changes look good. The thing 
which I think should also be addressed is updating the descriptions of the 
configuration options and the naming of the options/methods.
   
   Yes I will updated the names. thanks!
   
   I was also thinking of throwing an error instead of just logging a warning 
when the file/directory is missing. I can't really think of a case when a user 
would want a log instead of an error.
   
   What do you think @tillrohrmann ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to