JingsongLi commented on a change in pull request #13101:
URL: https://github.com/apache/flink/pull/13101#discussion_r468312570
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogGenericMetadataTest.java
##########
@@ -65,6 +69,43 @@ public void testGenericTableSchema() throws Exception {
}
}
+ @Test
+ public void testTableSchemaCompatibility() throws Exception {
+ catalog.createDatabase(db1, createDb(), false);
+ ObjectPath tablePath = new ObjectPath(db1, "generic110");
+
+ // create a table with old schema properties
+ Table hiveTable =
org.apache.hadoop.hive.ql.metadata.Table.getEmptyTable(tablePath.getDatabaseName(),
+ tablePath.getObjectName());
+ // create table generic110 (c char(265), vc varchar(65536), ts
timestamp(3), watermark for ts as ts)
+ hiveTable.setDbName(tablePath.getDatabaseName());
+ hiveTable.setTableName(tablePath.getObjectName());
+ hiveTable.getParameters().put(CatalogConfig.IS_GENERIC, "true");
Review comment:
Can we add tests for all types and watermarks and computed columns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
