wangyang0918 commented on a change in pull request #37:
URL: https://github.com/apache/flink-docker/pull/37#discussion_r468373814
##########
File path: docker-entrypoint.sh
##########
@@ -120,6 +120,16 @@ elif [ "$1" = "taskmanager" ]; then
envsubst < "${CONF_FILE}" > "${CONF_FILE}.tmp" && mv "${CONF_FILE}.tmp"
"${CONF_FILE}"
exec $(drop_privs_cmd) "$FLINK_HOME/bin/taskmanager.sh" start-foreground
"$@"
+elif [ "$1" = "native-k8s" ]; then
+ shift 1
+ copy_plugins_if_required
+
+ export _FLINK_HOME_DETERMINED=true
+ . $FLINK_HOME/bin/config.sh
+ export
FLINK_CLASSPATH="`constructFlinkClassPath`:$INTERNAL_HADOOP_CLASSPATHS"
+ # Start commands for jobmanager and taskmanager are generated by Flink
internally.
+ echo "Start command: $*"
+ exec bash -c "$@"
Review comment:
I am just keeping the same behavior with `kubernetes-entry.sh`. I think
you are right. We need to do `drop_privs_cmd` just like other commands.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
