xintongsong commented on a change in pull request #13004:
URL: https://github.com/apache/flink/pull/13004#discussion_r468464587
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/jobmanager/JobManagerFlinkMemory.java
##########
@@ -50,7 +53,8 @@
private final MemorySize jvmHeap;
private final MemorySize offHeapMemory;
- JobManagerFlinkMemory(MemorySize jvmHeap, MemorySize offHeapMemory) {
+ @VisibleForTesting
Review comment:
Exactly.
The constructor was package privacy. I made it public so it can be called in
the constructor of `JobManagerProcessSpec`. The later is for test purpose only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
