[
https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141409#comment-15141409
]
ASF GitHub Bot commented on FLINK-2021:
---------------------------------------
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-182520553
That's absolutely not a problem @fhueske, your remarks are reasonable and I
do appreciate the care you all take in making sure Flink turns out great. It's
my first non-trivial PR on Flink (or any major open source project, for that
matter) and the guidance you are both providing is extremely precious.
I agree with your remarks and will make sure to provide the required fixes
ASAP. Feel free to feed any more suggestions asynchronously, it's in the best
interest for the project to have a solid set of examples for newcomers and I'd
like to give a significant contribution.
One final question: when we feel that the refactoring is complete, should I
squash the commits coming from the PR review as well? Thanks in advance.
> Rework examples to use ParameterTool
> ------------------------------------
>
> Key: FLINK-2021
> URL: https://issues.apache.org/jira/browse/FLINK-2021
> Project: Flink
> Issue Type: Improvement
> Components: Examples
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Assignee: Stefano Baghino
> Priority: Minor
> Labels: starter
>
> In FLINK-1525, we introduced the {{ParameterTool}}.
> We should port the examples to use the tool.
> The examples could look like this (we should maybe discuss it first on the
> mailing lists):
> {code}
> public static void main(String[] args) throws Exception {
> ParameterTool pt = ParameterTool.fromArgs(args);
> boolean fileOutput = pt.getNumberOfParameters() == 2;
> String textPath = null;
> String outputPath = null;
> if(fileOutput) {
> textPath = pt.getRequired("input");
> outputPath = pt.getRequired("output");
> }
> // set up the execution environment
> final ExecutionEnvironment env =
> ExecutionEnvironment.getExecutionEnvironment();
> env.getConfig().setUserConfig(pt);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
