Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-182520553
That's absolutely not a problem @fhueske, your remarks are reasonable and I
do appreciate the care you all take in making sure Flink turns out great. It's
my first non-trivial PR on Flink (or any major open source project, for that
matter) and the guidance you are both providing is extremely precious.
I agree with your remarks and will make sure to provide the required fixes
ASAP. Feel free to feed any more suggestions asynchronously, it's in the best
interest for the project to have a solid set of examples for newcomers and I'd
like to give a significant contribution.
One final question: when we feel that the refactoring is complete, should I
squash the commits coming from the PR review as well? Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
