tillrohrmann opened a new pull request #13131:
URL: https://github.com/apache/flink/pull/13131


   ## What is the purpose of the change
   
   In order to serve the job execution result when using the per job mode, the 
REST
   handlers must be able to serve requests while the RestServerEndpoint is 
being shut
   down. Otherwise, it is not possible to serve the asynchronous operation 
results
   such as the job execution result.
   
   This commit solves this problem by checking whether the 
InFlightRequestTracker
   allows to enqueue a new request or not in the AbstractHandler. If it rejects 
a new
   request, this means that the handler has been shut completely shut down and 
that we
   should close the connection to the client. If the InFlightRequestTracker 
still accepts
   requests, then this means that the RestHandler might still want to serve an 
asynchronous
   result.
   
   cc @zentol 
   
   ## Verifying this change
   
   - Updated `RestServerEndpointITCase.testShouldWaitForHandlersWhenClosing` 
and 
`RestServerEndpointITCase.testRequestsRejectedAfterShutdownOfHandlerIsCompleted`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to