mbalassi commented on a change in pull request #13128: URL: https://github.com/apache/flink/pull/13128#discussion_r469766403
########## File path: flink-connectors/flink-connector-hbase/README.md ########## @@ -0,0 +1,97 @@ +# Flink HBase Connector + +This connector provides classes that allow access for Flink to [HBase](https://hbase.apache.org/). + +To use this connector, add the following dependency to your project: + + <dependency> Review comment: Since we are adding this into Flink calling out the version is not relevant here, we should omit the dependency from here. Possibly we should add this whole content to the docs instead. ########## File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java ########## @@ -610,7 +610,7 @@ private String createHBaseTableDDL(String tableName, boolean testTimeAndDecimalT family4Statement.toString() + ") WITH (\n" + " 'connector.type' = 'hbase',\n" + - " 'connector.version' = '1.4.3',\n" + + " 'connector.version' = '2.4.3',\n" + Review comment: `hbase-2.2.3` ########## File path: flink-connectors/flink-connector-hbase/README.md ########## @@ -0,0 +1,97 @@ +# Flink HBase Connector + +This connector provides classes that allow access for Flink to [HBase](https://hbase.apache.org/). + +To use this connector, add the following dependency to your project: + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-hbase_2.11</artifactId> + <version>1.11.0</version> + </dependency> + + *Version Compatibility*: This module is compatible with Apache HBase *2.2.3* (last stable version) and Apache Flink 1.11.+. Review comment: No need to call out Flink version if we are merging to Flink. 😺 ########## File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java ########## @@ -438,7 +438,7 @@ public void testHBaseLookupTableSource() throws Exception { " family4 ROW<col1 TIMESTAMP(3), col2 DATE, col3 TIME(3), col4 DECIMAL(12, 4)>," + " PRIMARY KEY (rowkey) NOT ENFORCED" + ") WITH (" + - " 'connector' = 'hbase-1.4'," + + " 'connector' = 'hbase-2.4'," + Review comment: `hbase-2.2` ########## File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java ########## @@ -623,7 +623,7 @@ private String createHBaseTableDDL(String tableName, boolean testTimeAndDecimalT " family3 ROW<col1 DOUBLE, col2 BOOLEAN, col3 VARCHAR>" + family4Statement.toString() + ") WITH (\n" + - " 'connector' = 'hbase-1.4',\n" + + " 'connector' = 'hbase-2.4',\n" + Review comment: `hbase-2.2` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
