xintongsong commented on a change in pull request #13004:
URL: https://github.com/apache/flink/pull/13004#discussion_r469863090
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/taskmanager/TaskExecutorFlinkMemory.java
##########
@@ -128,4 +130,31 @@ public MemorySize getJvmDirectMemorySize() {
public MemorySize getTotalFlinkMemorySize() {
return
frameworkHeap.add(frameworkOffHeap).add(taskHeap).add(taskOffHeap).add(network).add(managed);
}
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj == this) {
+ return true;
+ } else if (obj instanceof TaskExecutorFlinkMemory) {
+ TaskExecutorFlinkMemory that =
(TaskExecutorFlinkMemory) obj;
+ return Objects.equals(this.frameworkHeap,
that.frameworkHeap) &&
+ Objects.equals(this. frameworkOffHeap,
that.frameworkOffHeap) &&
+ Objects.equals(this. taskHeap,
that.taskHeap)&&
+ Objects.equals(this. taskOffHeap,
that.taskOffHeap)&&
+ Objects.equals(this. network,
that.network)&&
+ Objects.equals(this. managed,
that.managed);
Review comment:
Nice catch. That should be a typo + copy/paste problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
