RocMarshal commented on pull request #13059:
URL: https://github.com/apache/flink/pull/13059#issuecomment-674711056
> I'm fine with this change, and the change LGTM. but I'm not very sure if
we'll accept such change or do we want to replace all the `{site.baseurl}` with
`{% link %}` in one commit.
Hi, @klion26 .
Thank you for your response.
The original reason for proposing such hotfix PR is to keep consistent with
my translation work. Whenever I complete the corresponding translation page, I
will review the corresponding original page. If there is something that needs
to be improved, I hope to put it in one commit. However, it seems that it is
not recommended to put it in one commit
([PR12798](https://github.com/apache/flink/pull/12798#discussion_r450615831)).
Therefore, I put the similar hotfix into a commit separately. If it might seem
insignificant, I will close the PR. In the future, I will not do such
operations again and only complete the works described in the corresponding
JIRAs.
Of course, at present, I prefer the latter that sounds get twice the result
with half the effort.
@alpinegizmo @klion26
Could you tell me more details about your suggestions?
Thank you .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
